This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Fix -Os related build and test failures.


On 10/31/2016 04:33 AM, Andreas Schwab wrote:
> https://build.opensuse.org/project/monitor/home:Andreas_Schwab:glibc
> 
> In file included from strxfrm_l.c:48:0:
> ../locale/weight.h: In function ‘findidx’:
> ../locale/weight.h:69:4: error: ‘DIAG_PUSH_NEEDS_COMMENT’ undeclared (first use in this function)
>     DIAG_PUSH_NEEDS_COMMENT;
>     ^~~~~~~~~~~~~~~~~~~~~~~
> ../locale/weight.h:69:4: note: each undeclared identifier is reported only once for each function it appears in
> ../locale/weight.h:70:4: error: implicit declaration of function ‘DIAG_IGNORE_Os_NEEDS_COMMENT’ [-Werror=implicit-function-declaration]
>     DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../locale/weight.h:74:4: error: ‘DIAG_POP_NEEDS_COMMENT’ undeclared (first use in this function)
>     DIAG_POP_NEEDS_COMMENT;
>     ^~~~~~~~~~~~~~~~~~~~~~

I'm fixing this. I don't know why this didn't fail on my x86_64 build.

I'm moving the #include <libc-internal.h> into the weight header fragments.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]