This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()
- From: Sergei Trofimovich <slyich at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: libc-alpha at sourceware dot org, Sergei Trofimovich <siarheit at google dot com>, Roland McGrath <roland at hack dot frob dot com>
- Date: Sat, 29 Oct 2016 17:15:27 +0100
- Subject: Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()
- Authentication-results: sourceware.org; auth=none
- References: <20161029134801.15082-1-slyich@gmail.com> <87pomjnp3v.fsf@linux-m68k.org>
On Sat, 29 Oct 2016 17:37:08 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Okt 29 2016, slyich@gmail.com wrote:
>
> > commit 96e1bff2513873062233a13c7fd1eea57bb8db24
> > Author: Roland McGrath <roland@gnu.org>
> > Date: Wed Jul 17 18:00:33 1996 +0000
>
> ??? This commit touches csu/initfini.c only.
>
> Andreas.
I was looking at this tree:
Commit https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=96e1bff2513873062233a13c7fd1eea57bb8db24
among other thing shows disappearance of 'case R_68K_NONE':
-static inline void
-elf_machine_lazy_rel (struct link_map *map, const Elf32_Rela *reloc)
-{
- Elf32_Addr *const reloc_addr = (void *) (map->l_addr + reloc->r_offset);
- switch (ELF32_R_TYPE (reloc->r_info))
- {
- case R_68K_NONE:
- break;
- case R_68K_JMP_SLOT:
- *reloc_addr += map->l_addr;
- break;
- default:
- assert (! "unexpected PLT reloc type");
- break;
- }
-}
+static inline void
+elf_machine_lazy_rel (struct link_map *map, const Elf32_Rela *reloc)
+{
+ Elf32_Addr *const reloc_addr = (void *) (map->l_addr + reloc->r_offset);
+ switch (ELF32_R_TYPE (reloc->r_info))
+ {
+ case R_68K_JMP_SLOT:
+ *reloc_addr += map->l_addr;
+ break;
+ default:
+ assert (! "unexpected PLT reloc type");
+ break;
+ }
+}
--
Sergei