This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone()
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Fri, 28 Oct 2016 07:58:07 -0400
- Subject: Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone()
- Authentication-results: sourceware.org; auth=none
- References: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com>
On 10/21/2016 05:06 PM, Tulio Magno Quites Machado Filho wrote:
> Use a function call to _exit() so that the linker can create a TOC stub
> instead of just a branch.
>
> 2016-10-21 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>
> [BZ #20728]
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Replace a
> branch to _exit() by a function call.
> ---
> sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> index 7c59b9b..df824f5 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> @@ -97,7 +97,7 @@ L(oldpid):
> #ifdef SHARED
> b JUMPTARGET(__GI__exit)
> #else
> - b JUMPTARGET(_exit)
> + bl JUMPTARGET(_exit)
> /* We won't ever get here but provide a nop so that the linker
> will insert a toc adjusting stub if necessary. */
> nop
I agree with Adhemerval that this _looks_ good, but you'd have to claim
it works _and_ review the final linked code generated by the static linker.
--
Cheers,
Carlos.