This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use read_int in vfscanf
- From: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org, joseph at codesourcery dot com
- Date: Wed, 26 Oct 2016 10:56:11 -0200
- Subject: Re: [PATCH] Use read_int in vfscanf
- Authentication-results: sourceware.org; auth=none
- References: <1474595428-20601-1-git-send-email-gftg@linux.vnet.ibm.com> <482ccd6e-5d17-c87f-2033-030493118f70@redhat.com>
On Thu, 6 Oct 2016 14:21:39 +0200
Florian Weimer <fweimer@redhat.com> wrote:
> On 09/23/2016 03:50 AM, Gabriel F. T. Gomes wrote:
>
> > + argpos = read_int ((const UCHAR_T **) &f);
>
> This is a const char * → const unsigned char * cast in the non-wide case
> (and okay), but in the wide case, it goes from const int * to const
> unsigned int *, which is not valid. This is a pre-existing issue in
> vfprintf.c, so I don't think it should block inclusion of this cleanup.
Thanks. Pushed as 726d48ec.