This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/3] Consolidate posix_fallocate{64} implementations
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Wed, 5 Oct 2016 23:49:27 +0530
- Subject: Re: [PATCH v2 2/3] Consolidate posix_fallocate{64} implementations
- Authentication-results: sourceware.org; auth=none
- References: <1475021701-22246-1-git-send-email-adhemerval.zanella@linaro.com> <1475021701-22246-2-git-send-email-adhemerval.zanella@linaro.com> <7eec23ad-6e2d-af4d-6c62-6b5ef1b4b851@gotplt.org> <c5829c8b-1c2b-5508-0945-395f6cb2e821@linaro.org>
On Wednesday 05 October 2016 11:20 PM, Adhemerval Zanella wrote:
> What about the new definition I sent with fallocate update patch:
>
> #define FAIL(...) \
> ({ \
> printf ("error: line %d: ", __LINE__); \
> printf (__VA_ARGS__); \
> printf ("\n"); \
> return 1; \
> })
>
> I think I can rename to FAIL_RET to explicit state it returns and maybe
> add a RET_EXIT with same logic but calling exit.
Yeah, this is the one I was referring to. FAIL_RET sounds good along
with a FAIL_EXIT.
Siddhesh