This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 10/13] Installed-header hygiene (BZ#20366): struct ether_addr.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Cc: joseph at codesourcery dot com
- Date: Wed, 21 Sep 2016 15:51:01 -0400
- Subject: Re: [PATCH 10/13] Installed-header hygiene (BZ#20366): struct ether_addr.
- Authentication-results: sourceware.org; auth=none
- References: <20160830011645.25769-1-zackw@panix.com> <20160830011645.25769-2-zackw@panix.com> <20160830011645.25769-3-zackw@panix.com> <20160830011645.25769-4-zackw@panix.com> <20160830011645.25769-5-zackw@panix.com> <20160830011645.25769-6-zackw@panix.com> <20160830011645.25769-7-zackw@panix.com> <20160830011645.25769-8-zackw@panix.com> <20160830011645.25769-9-zackw@panix.com> <20160830011645.25769-10-zackw@panix.com> <20160830011645.25769-11-zackw@panix.com>
On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> Some versions of netinet/if_ether.h only define struct ether_addr when
> __USE_MISC. This breaks function prototypes in netinet/ether.h that
> depend on it. The path of least resistance is to condition those
> declarations on __USE_MISC too.
>
> * inet/netinet/if_ether.h: Condition all function prototypes
> on __USE_MISC, to ensure struct ether_addr is declared.
Wrong ChangeLog path?
LGTM.
Linux does define an if_ether.h, but it uses struct ethhdr instead which
doesn't conflict.
--
Cheers,
Carlos.