This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] struct stat: don't typecast to struct kernel_stat were not needed
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Chris Metcalf <cmetcalf at mellanox dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 6 Sep 2016 19:26:57 +0300
- Subject: Re: [PATCH] struct stat: don't typecast to struct kernel_stat were not needed
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1473161326-23562-1-git-send-email-ynorov@caviumnetworks.com> <d5cd7faf-71fb-4e38-eaff-02955ff2f9dd@mellanox.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
> On 9/6/2016 7:28 AM, Yury Norov wrote:
> >The cast comes from the beginning of the git history, and probably was needed
> >when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> >breaks build if struct kernel_stat is not declared.
> >
> > * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> > * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
> >
> >Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
>
> I think you mean "where not needed" in the commit subject.
Yes. Should I resend it?