This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] Make common fdim implementation generic.
On Tue, 30 Aug 2016, Paul E. Murphy wrote:
> /* Define compat symbols for long double on platforms
> where it was not always a distinct type. */
> -#define M_LIBM_NEED_COMPAT(f) \
> - LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
> +#if !defined M_LIBM_NEED_COMPAT
> +# define M_LIBM_NEED_COMPAT(f) \
> + LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version)
Two-column indentation is still correct for the continuation line; it
should not be changed.
> -#define declare_mgen_libm_compat(from, to) \
> - compat_symbol (libm, from, to ## l, \
> +#if !defined declare_mgen_libm_compat
> +# define declare_mgen_libm_compat(from, to) \
> + compat_symbol (libm, from, to ## l, \
> LDOUBLE_ ## to ## l_libm_version);
Likewise here (if a change were correct, the following line would have
needed reindenting as well to stay aligned with the '(').
> -#define declare_mgen_alias(from, to) \
> - long_double_symbol (libm, from ## l, to ## l);
> +#if !defined declare_mgen_alias
> +# define declare_mgen_alias(from, to) \
> + long_double_symbol (libm, from ## l, to ## l);
Likewise here.
OK with those fixes.
--
Joseph S. Myers
joseph@codesourcery.com