This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 5/9] ppc: Use libc_ifunc macro for time, gettimeofday.

From: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
Cc: fweimer at redhat dot com, schwab at linux-m68k dot org, joseph_myers at mentor dot com
Date: Tue, 30 Aug 2016 08:46:35 -0500
Subject: Re: [PATCH v3 5/9] ppc: Use libc_ifunc macro for time, gettimeofday.
Authentication-results: sourceware.org; auth=none
References: <1472047472-30307-1-git-send-email-stli@linux.vnet.ibm.com> <1472047472-30307-5-git-send-email-stli@linux.vnet.ibm.com>


On 08/24/2016 09:04 AM, Stefan Liebler wrote:
> This patch uses the libc_ifunc_hidden macro to create already existing ifunc functions
> time and gettimeofday on power. This way, the libc_hidden_def macro can be used
> instead of inline assemblies.
> On ppc32, the __GI_* symbols do not target the ifunc symbol and thus the
> redirection construct has to be applied here.
> 
> ChangeLog:
> 
> 	* sysdeps/unix/sysv/linux/powerpc/gettimeofday.c (__gettimeofday):
> 	Use libc_ifunc_hidden and libc_hidden_def macro. Redirect ifunced function
> 	in header for using it as type for ifunc function because __GI_* symbols
> 	for ppc32 do not target the ifunc symbols.
> 	* sysdeps/unix/sysv/linux/powerpc/time.c (time): Likewise.

This patch looks ok to me.

References:
- [PATCH v3 1/9] Add configure check to test if gcc supports attribute ifunc.
  - From: Stefan Liebler
- [PATCH v3 5/9] ppc: Use libc_ifunc macro for time, gettimeofday.
  - From: Stefan Liebler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]