This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 3/9] s390: Refactor ifunc resolvers due to false debuginfo.

From: Florian Weimer <fweimer at redhat dot com>
To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
Cc: murphyp at linux dot vnet dot ibm dot com, schwab at linux-m68k dot org, joseph_myers at mentor dot com
Date: Tue, 30 Aug 2016 14:31:08 +0200
Subject: Re: [PATCH v3 3/9] s390: Refactor ifunc resolvers due to false debuginfo.
Authentication-results: sourceware.org; auth=none
References: <1472047472-30307-1-git-send-email-stli@linux.vnet.ibm.com> <1472047472-30307-3-git-send-email-stli@linux.vnet.ibm.com>

On 08/24/2016 04:04 PM, Stefan Liebler wrote:

 #if defined SHARED && IS_IN (libc)
+# define mempcpy __redirect_mempcpy
+# define __mempcpy __redirect___mempcpy
+/* Omit the mempcpy inline definitions because it would redefine mempcpy.  */
+# define _HAVE_STRING_ARCH_mempcpy 1
+# include <string.h>
+# undef mempcpy
+# undef __mempcpy
 # include <ifunc-resolve.h>

The long-term maintainability of such #define trickery still concernsme. What would be needed to avoid that?


(This obviously shouldn't be part of this patch sequence, I'm just curious.)

Thanks,
Florian

Follow-Ups:
- Re: [PATCH v3 3/9] s390: Refactor ifunc resolvers due to false debuginfo.
  - From: Stefan Liebler

References:
- [PATCH v3 1/9] Add configure check to test if gcc supports attribute ifunc.
  - From: Stefan Liebler
- [PATCH v3 3/9] s390: Refactor ifunc resolvers due to false debuginfo.
  - From: Stefan Liebler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]