This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [09/12] Add fesetexcept: powerpc
On 08/11/2016 04:02 PM, Joseph Myers wrote:
> This patch adds PowerPC versions of fesetexcept.
>
> 2016-08-11 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/powerpc/fpu/fesetexcept.c: New file.
> * sysdeps/powerpc/nofpu/fesetexcept.c: Likewise.
> * sysdeps/powerpc/powerpc32/e500/nofpu/fesetexcept.c: Likewise.
>
> diff --git a/sysdeps/powerpc/fpu/fesetexcept.c b/sysdeps/powerpc/fpu/fesetexcept.c
> new file mode 100644
> index 0000000..b7f2e06
> --- /dev/null
> +++ b/sysdeps/powerpc/fpu/fesetexcept.c
> @@ -0,0 +1,41 @@
> +/* Set given exception flags. PowerPC version.
> + Copyright (C) 2016 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <fenv_libc.h>
> +
> +int
> +fesetexcept (int excepts)
> +{
> + fenv_union_t u, n;
> +
> + u.fenv = fegetenv_register ();
> + n.l = (u.l
> + | (excepts & FPSCR_STICKY_BITS)
> + | (excepts >> ((31 - FPSCR_VX) - (31 - FPSCR_VXSOFT))
> + & FE_INVALID_SOFTWARE));
This should also preserve a comment about transforming
FE_INVALID into FE_INVALID_SOFTWARE. Otherwise, this patch
looks OK to me.