This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 03/11] Support for type-generic libm function implementations libm


On Wed, 10 Aug 2016, Paul E. Murphy wrote:

> diff --git a/math/Makefile b/math/Makefile
> index 567b7ed..7451e4e 100644
> --- a/math/Makefile
> +++ b/math/Makefile
> @@ -274,7 +274,7 @@ generated += $(addsuffix .c,$(call type-foreach,$(gen-libm-calls:%=%$(s)))) \
>  # Create wrappers in the math build directory.
>  $(objpfx)gen-libm-templates.stmp:
>         for gfunc in $(gen-libm-calls); do                                \
> -         gfunc_basefile=$${gfunc/F/}_template.c;                         \
> +         gfunc_basefile=$${gfunc%F*}$${gfunc#*F}_template.c;             \
>           for type in $(foreach t,$(types),$(t)__$(type-$(t)-suffix)); do \
>             func=$(objpfx)$${gfunc/F/$${type#*__}};                       \

There's a further unfixed instance of this non-POSIX shell usage.

Please send a complete fixed patch.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]