This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] linux ttyname and ttyname_r: return link if appropriate

From: Mike Frysinger <vapier at gentoo dot org>
To: "Serge E. Hallyn" <serge at hallyn dot com>
Cc: Serge Hallyn <serge dot hallyn at ubuntu dot com>, libc-alpha at sourceware dot org
Date: Sat, 6 Aug 2016 04:45:59 -0400
Subject: Re: [PATCH] linux ttyname and ttyname_r: return link if appropriate
Authentication-results: sourceware.org; auth=none
References: <20160415184746.GA10830@ubuntumail> <20160415195938.GP6588@vapier.lan> <20160418195318.GB30476@ubuntumail> <20160418200222.GY5369@vapier.lan> <20160418202301.GA30919@ubuntumail> <20160420021012.GA19449@ubuntumail> <20160420022823.GT5369@vapier.lan> <20160420185141.GA31095@ubuntumail> <20160727165711.GA27815@altlinux.org> <20160806020855.GA19897@mail.hallyn.com>

On 05 Aug 2016 21:08, Serge E. Hallyn wrote:
>  #ifdef _STATBUF_ST_RDEV
>  	  && S_ISCHR (st1.st_mode)
>  	  && st1.st_rdev == st.st_rdev
> +	  && st1.st_dev == st.st_dev
> +	  && st1.st_ino == st.st_ino
>  #else
>  	  && st1.st_ino == st.st_ino
>  	  && st1.st_dev == st.st_dev
>  #endif

wouldn't it be better to shuffle the ifdef then ?
	#ifdef _STATBUF_ST_RDEV
		&& S_ISCHR (st1.st_mode)
		&& st1.st_rdev == st.st_rdev
	#endif
		&& st1.st_ino == st.st_ino
		&& st1.st_dev == st.st_dev)
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] linux ttyname and ttyname_r: return link if appropriate
  - From: Serge E. Hallyn

References:
- [PATCH] linux ttyname and ttyname_r: return link if appropriate
  - From: Serge E. Hallyn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]