This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: Use sysdep.o from libc.a in static libraries
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Thu, 4 Aug 2016 11:57:24 -0400
- Subject: Re: [PATCH] x86: Use sysdep.o from libc.a in static libraries
- Authentication-results: sourceware.org; auth=none
- References: <e08f67d1-988d-ffe6-1ff8-cc304baae8bf@redhat.com>
On 08/04/2016 05:19 AM, Florian Weimer wrote:
> Fedora needs to relink libpthread.a into a single object file to
> support some application needs. Starting with
>
> commit fb1cf108115f7e2e4510859693431b3473657d77
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Tue Oct 13 11:58:53 2015 -0700
>
> Add INLINE_SYSCALL_ERROR_RETURN_VALUE
>
> this prevents static linking due to multiple copies of the functions
> from sysdep.o.
>
> The attached patch skips adding sysdep.o for static libraries. Okay
> to commit?
>
> (No bug filed because this is a downstream bug only, but dropping the
> additional copy of sysdep.o seems to make sense upstream as well.)
Just to be clear: User visible changes need bugs, downstream or not.
I leave it up to you to decide if you want a bug to track this or not,
I'm not picky since this is an odd case where any change is visible
as a change in the statically linked objects.
--
Cheers,
Carlos.