This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 2/3] 32-bit ABIs: support stat syscall family
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <schwab at suse dot de>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, <bamvor dot zhangjian at huawei dot com>, <fweimer at redhat dot com>, <Prasun dot Kapoor at cavium dot com>, <adhemerval dot zanella at linaro dot org>
- Date: Thu, 4 Aug 2016 12:40:29 +0000
- Subject: Re: [PATCH v4 2/3] 32-bit ABIs: support stat syscall family
- Authentication-results: sourceware.org; auth=none
- References: <1470304959-9944-1-git-send-email-ynorov@caviumnetworks.com> <1470304959-9944-3-git-send-email-ynorov@caviumnetworks.com>
On Thu, 4 Aug 2016, Yury Norov wrote:
> diff --git a/sysdeps/unix/sysv/linux/generic/bits/stat.h b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> index 8e3f745..85e9866 100644
> --- a/sysdeps/unix/sysv/linux/generic/bits/stat.h
> +++ b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> @@ -41,7 +41,7 @@
> /* Versions of the `xmknod' interface. */
> #define _MKNOD_VER_LINUX 0
>
> -#if defined __USE_FILE_OFFSET64
> +#if defined (__USE_FILE_OFFSET64) || defined (XSTAT_IS_XSTAT64)
As has been explained to you several times, XSTAT_IS_XSTAT64 is in the
user's namespace and must not be referenced in any installed header.
> +# if SUPPORT_64BIT_TIME_TYPES
Likewise SUPPORT_64BIT_TIME_TYPES.
Please stop posting any more patches to libc-alpha until you have done a
thorough review of all the previous libc-alpha discussions of AArch64
ILP32 patches over the past few years and properly understood the issues
involved and properly addressed them in your patches. By now, your patch
postings are just wasting people's time, and this is not acceptable;
there's no point seeking review if you keep ignoring the issues raised.
> +#if defined (__USE_FILE_OFFSET64) || defined (XSTAT_IS_XSTAT64)
Likewise.
> +#ifdef XSTAT_IS_XSTAT64
Likewise.
> --- a/time/time.h
> +++ b/time/time.h
> @@ -65,6 +65,17 @@ __USING_NAMESPACE_STD(clock_t)
> #endif /* clock_t not defined and <time.h> or need clock_t. */
> #undef __need_clock_t
>
> +#ifndef SUPPORT_64BIT_TIME_TYPES
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com