This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add test for correct calculation of dl_phdr_info.dlpi_subs

From: Mike Frysinger <vapier at gentoo dot org>
To: Gleb Natapov <gleb at scylladb dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 2 Aug 2016 12:07:34 -0400
Subject: Re: [PATCH] add test for correct calculation of dl_phdr_info.dlpi_subs
Authentication-results: sourceware.org; auth=none
References: <20160801122008.GO2502@scylladb.com>

On 01 Aug 2016 15:20, Gleb Natapov wrote:
> --- /dev/null
> +++ b/elf/tst-dlpi_subs.c
> @@ -0,0 +1,33 @@
> +#include <dlfcn.h>
> +#include <stdio.h>

please put a proper comment block at the top (copyright/license) and a
short blurb explaining what the test does.

> +static int fail = false;

"false" is for bool types, not int types
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] add test for correct calculation of dl_phdr_info.dlpi_subs
  - From: Gleb Natapov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]