This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/4] Revised^2: deprecate major/minor/makedev in sys/types.h


I think these patch set is ok for inclusion and the comments from Mike
Frysinger in part 02 seems more stylist than functional (which I think
should not be a blocker).

I rebased the remaining patches in a branch [1] so you could check if I
am missing something.

[1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/deprecate-makedev

On 13/05/2016 10:26, Zack Weinberg wrote:
> I'm about to go out of town for two weeks, so here is the current state
> of the patches to deprecate exposure of major/minor/makedev by sys/types.h.
> 
> I believe this addresses all of the review comments to date, *except*
> Roland's request for a generic __glibc_has_feature mechanism.  That is
> going to take more thought and, given Carlos wanted this patch in 2.24,
> which I think is freezing at the end of June(?), I don't think it makes
> sense to delay this for that.
> 
> Moving sysdeps/generic/bits/hwcap.h is unconnected to the primary goal of
> this patch series; it just happens to be the only file still in
> sysdeps/generic/bits and, AFAICT, it should never have been there in the
> first place (see discussion elsewhere).
> 
> zw
> 
> Zack Weinberg (4):
>   Move sysdeps/generic/bits/hwcap.h to top-level bits/.
>   Minimize sysdeps code involved in defining major/minor/makedev.
>   Add utility macros for clang detection, and deprecation with messages.
>   Deprecate inclusion of <sys/sysmacros.h> by <sys/types.h>
> 
>  NEWS                                               |  15 +++
>  bits/hwcap.h                                       |  23 +++++
>  bits/sysmacros.h                                   |  60 ++++++++++++
>  include/features.h                                 |  19 +++-
>  include/sys/sysmacros.h                            |   1 +
>  misc/Makefile                                      |   8 +-
>  misc/Versions                                      |   3 +
>  misc/makedev.c                                     |  40 ++++++++
>  misc/sys/cdefs.h                                   |  22 ++++-
>  misc/sys/sysmacros.h                               |  98 +++++++++++++++++++
>  misc/tst-makedev.c                                 | 104 +++++++++++++++++++++
>  posix/Makefile                                     |   2 +-
>  posix/sys/types.h                                  |   8 +-
>  sysdeps/arm/nacl/libc.abilist                      |   4 +
>  sysdeps/generic/bits/hwcap.h                       |  23 -----
>  sysdeps/generic/sys/sysmacros.h                    |  30 ------
>  sysdeps/unix/sysv/linux/Makefile                   |   2 +-
>  sysdeps/unix/sysv/linux/aarch64/libc.abilist       |   1 +
>  sysdeps/unix/sysv/linux/alpha/libc.abilist         |   1 +
>  sysdeps/unix/sysv/linux/arm/libc.abilist           |   1 +
>  sysdeps/unix/sysv/linux/hppa/libc.abilist          |   1 +
>  sysdeps/unix/sysv/linux/i386/libc.abilist          |   1 +
>  sysdeps/unix/sysv/linux/ia64/libc.abilist          |   1 +
>  sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist |   1 +
>  sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist   |   1 +
>  sysdeps/unix/sysv/linux/makedev.c                  |  40 --------
>  sysdeps/unix/sysv/linux/microblaze/libc.abilist    |   1 +
>  .../unix/sysv/linux/mips/mips32/fpu/libc.abilist   |   1 +
>  .../unix/sysv/linux/mips/mips32/nofpu/libc.abilist |   1 +
>  .../unix/sysv/linux/mips/mips64/n32/libc.abilist   |   1 +
>  .../unix/sysv/linux/mips/mips64/n64/libc.abilist   |   1 +
>  sysdeps/unix/sysv/linux/nios2/libc.abilist         |   1 +
>  .../sysv/linux/powerpc/powerpc32/fpu/libc.abilist  |   1 +
>  .../linux/powerpc/powerpc32/nofpu/libc.abilist     |   1 +
>  .../sysv/linux/powerpc/powerpc64/libc-le.abilist   |   1 +
>  .../unix/sysv/linux/powerpc/powerpc64/libc.abilist |   1 +
>  sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist  |   1 +
>  sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist  |   1 +
>  sysdeps/unix/sysv/linux/sh/libc.abilist            |   1 +
>  sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist |   1 +
>  sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist |   1 +
>  sysdeps/unix/sysv/linux/sys/sysmacros.h            |  65 -------------
>  .../sysv/linux/tile/tilegx/tilegx32/libc.abilist   |   1 +
>  .../sysv/linux/tile/tilegx/tilegx64/libc.abilist   |   1 +
>  sysdeps/unix/sysv/linux/x86_64/64/libc.abilist     |   1 +
>  sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist    |   1 +
>  46 files changed, 425 insertions(+), 169 deletions(-)
>  create mode 100644 bits/hwcap.h
>  create mode 100644 bits/sysmacros.h
>  create mode 100644 include/sys/sysmacros.h
>  create mode 100644 misc/makedev.c
>  create mode 100644 misc/sys/sysmacros.h
>  create mode 100644 misc/tst-makedev.c
>  delete mode 100644 sysdeps/generic/bits/hwcap.h
>  delete mode 100644 sysdeps/generic/sys/sysmacros.h
>  delete mode 100644 sysdeps/unix/sysv/linux/makedev.c
>  delete mode 100644 sysdeps/unix/sysv/linux/sys/sysmacros.h
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]