This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] all: #define __WORDSIZE32_SIZE_ULONG and __WORDSIZE32_PTRDIFF_LONG everywhere
- From: Andreas Schwab <schwab at suse dot de>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <joseph at codesourcery dot com>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, <bamvor dot zhangjian at huawei dot com>, <fweimer at redhat dot com>, <Prasun dot Kapoor at cavium dot com>, <adhemerval dot zanella at linaro dot org>, Andrew Pinski <apinski at cavium dot com>
- Date: Thu, 07 Jul 2016 00:54:27 +0200
- Subject: Re: [PATCH] all: #define __WORDSIZE32_SIZE_ULONG and __WORDSIZE32_PTRDIFF_LONG everywhere
- Authentication-results: sourceware.org; auth=none
- References: <1467843094-2914-1-git-send-email-ynorov@caviumnetworks.com>
Yury Norov <ynorov@caviumnetworks.com> writes:
> diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h
> new file mode 100644
> index 0000000..8bcbea9
> --- /dev/null
> +++ b/sysdeps/aarch64/bits/wordsize.h
> @@ -0,0 +1,29 @@
> +/* Determine the wordsize from the preprocessor defines.
> +
> + Copyright (C) 2016 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#ifdef __LP64__
> +# define __WORDSIZE 64
> +# define __WORDSIZE32_SIZE_ULONG 0
> +# define __WORDSIZE32_PTRDIFF_LONG 0
> +#else
> +# define __WORDSIZE 32
> +# define __WORDSIZE32_SIZE_ULONG 1
> +# define __WORDSIZE32_PTRDIFF_LONG 1
> +#endif
There should be a comment explaining their meaning.
> +
Trailing empty line (in all files).
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."