This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC PATCH] [AARCH64] ILP32: support stat syscall family
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, <bamvor dot zhangjian at huawei dot com>, <schwab at suse dot de>, <Prasun dot Kapoor at cavium dot com>, <adhemerval dot zanella at linaro dot org>, Yury Norov <yury dot norov at gmail dot com>
- Date: Mon, 4 Jul 2016 15:04:59 +0300
- Subject: Re: [RFC PATCH] [AARCH64] ILP32: support stat syscall family
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1467291615-30356-1-git-send-email-ynorov@caviumnetworks.com> <alpine.DEB.2.20.1606301347050.27126@digraph.polyomino.org.uk> <20160701090301.GA14016@yury-N73SV> <f831d08f-7774-3548-c141-a0a9ca46f311@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, Jul 04, 2016 at 12:43:19PM +0200, Florian Weimer wrote:
> On 07/01/2016 11:03 AM, Yury Norov wrote:
> >On Thu, Jun 30, 2016 at 01:51:22PM +0000, Joseph Myers wrote:
> >>On Thu, 30 Jun 2016, Yury Norov wrote:
> >>
> >>> - __32_BIT_ABI_SUPPORTS_64_BIT_TIME_T macro introduced to indicate that 32-bit
> >>> ABI has struct __timespec (and maybe __timeval in future) that is compatible
> >>> to 64-bit _timespec;
> >>
> >>You can't add a macro to one architecture like that then use it in generic
> >>code. You have to define it in *every* architecture's bits/typesizes.h
> >>before it can be used in generic code.
> >
> >Is it OK to do like this then?
> >#define __32_BIT_ABI_SUPPORTS_64_BIT_TIME_T /* w/o 1 or 0 */
> >
> >Where's a proper place for it? In features.h maybe?
>
> How do you propose to set the default and add the architecture-specific
> overrides?
>
> Thanks,
> Florian
I don't know. I'm experimenting with it, but have no answer yet.
Is there standard way to add new option to glibc, and not to set it to 0
in all unrelated ports?
As now, the best option I see is to define all needed options in arch
header, and then use #inclure_next.
Yury