This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Check GLIBC_IFUNC to enable/disable ifunc features
- From: Andreas Schwab <schwab at suse dot de>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 30 Jun 2016 16:33:31 +0200
- Subject: Re: PATCH: Check GLIBC_IFUNC to enable/disable ifunc features
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOq1+_rMbs1mt3=Md=Wx=7ZxUbD+BhOx-qrO5TBRBrRLww at mail dot gmail dot com> <20160630030947 dot GD3824 at devel dot intra dot reserved-bit dot com> <CAMe9rOrd+DEP1POnXaUaOrCaGqMmrftJbR_6ydFCXQeWueWmag at mail dot gmail dot com> <20160630034351 dot GE3824 at devel dot intra dot reserved-bit dot com> <CAMe9rOpNGtU=mVWEC5fvAABD_bkdM=8kx49KOc_yYkEXiPfx=w at mail dot gmail dot com> <20160630114416 dot GA7564 at devel dot intra dot reserved-bit dot com> <CAMe9rOp0z6coVK51_wp=s1zJaYA0wyVt2+ZJE1qHTqCQjexgKw at mail dot gmail dot com> <20160630125142 dot GB7564 at devel dot intra dot reserved-bit dot com> <CAMe9rOpstKCZgv8_LjpTp7=nZzNXduouDViqvwMtRTfbKC0iAw at mail dot gmail dot com> <20160630142318 dot GC7564 at devel dot intra dot reserved-bit dot com>
Siddhesh Poyarekar <siddhesh@sourceware.org> writes:
> On Thu, Jun 30, 2016 at 06:42:30AM -0700, H.J. Lu wrote:
>> comma-separator is fine. But we need to both turn it on and off.
>
> How about this:
>
> empty string == all disabled
> special keyword 'all' == all enabled
> comma-separated list == those enabled and rest disabled.
I think it is useful to be able to selectively disable some features, by
prefixing it with - for example.
>> Also do we need _X86? GLIBC_IFUNC is processor specific. Why
>> pollute environment with
>>
>> GLIBC_IFUNC_ARM
>> GLIBC_IFUNC_X86
>
> Fair enough.
Only if unknown features are ignored.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."