This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: "Zhangjian (Bamvor)" <bamvor dot zhangjian at huawei dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <joseph at codesourcery dot com>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>, <gaoyongliang at huawei dot com>
- Date: Thu, 23 Jun 2016 07:54:27 +0300
- Subject: Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-21-git-send-email-ynorov at caviumnetworks dot com> <mvmh9cnrn10 dot fsf at hawking dot suse dot de> <57692C1F dot 8050309 at huawei dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Jun 21, 2016 at 07:59:27PM +0800, Zhangjian (Bamvor) wrote:
> Hi,
>
> On 2016/6/21 15:58, Andreas Schwab wrote:
> >Yury Norov <ynorov@caviumnetworks.com> writes:
> >
> >>diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h
> >>index e8c4a7b..351d6bb 100644
> >>--- a/sysdeps/unix/sysv/linux/sysdep-vdso.h
> >>+++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h
> >>@@ -37,7 +37,7 @@
> >> __label__ out; \
> >> __label__ iserr; \
> >> INTERNAL_SYSCALL_DECL (sc_err); \
> >>- long int sc_ret; \
> >>+ __syscall_slong_t sc_ret; \
> >> \
> >> __typeof (__vdso_##name) vdsop = __vdso_##name; \
> >> PTR_DEMANGLE (vdsop); \
> >>@@ -64,7 +64,7 @@
> >> # define INTERNAL_VSYSCALL(name, err, nr, args...) \
> >> ({ \
> >> __label__ out; \
> >>- long v_ret; \
> >>+ __syscall_slong_t v_ret; \
> >> \
> >> __typeof (__vdso_##name) vdsop = __vdso_##name; \
> >> PTR_DEMANGLE (vdsop); \
> >
> >That part should have no effect now that __SYSCALL_SLONG_TYPE remains to
> >be long.
> Agree. According to the discussion in "[PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed
> always via 64bit values.". We should update this to long long too.
>
I think comment to patch 11 is outdated. Andreas right, this chunk is
useless. I'll remove it in next submission.