This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)
- From: Arnd Bergmann <arnd at arndb dot de>
- To: libc-alpha at sourceware dot org
- Cc: Andreas Schwab <schwab at suse dot de>, "Zhangjian (Bamvor)" <bamvor dot zhangjian at huawei dot com>, Yury Norov <ynorov at caviumnetworks dot com>, catalin dot marinas at arm dot com, linux-arm-kernel at lists dot infradead dot org, linux-kernel at vger dot kernel dot org, linux-doc at vger dot kernel dot org, linux-arch at vger dot kernel dot org, schwidefsky at de dot ibm dot com, heiko dot carstens at de dot ibm dot com, pinskia at gmail dot com, broonie at kernel dot org, joseph at codesourcery dot com, christoph dot muellner at theobroma-systems dot com, szabolcs dot nagy at arm dot com, klimov dot linux at gmail dot com, Nathan_Lynch at mentor dot com, agraf at suse dot de, Prasun dot Kapoor at caviumnetworks dot com, kilobyte at angband dot pl, geert at linux-m68k dot org, philipp dot tomsich at theobroma-systems dot com, manuel dot montezelo at gmail dot com, linyongting at huawei dot com, maxim dot kuvyrkov at linaro dot org, davem at davemloft dot net, Andrew Pinski <Andrew dot Pinski at caviumnetworks dot com>
- Date: Tue, 21 Jun 2016 17:47:44 +0200
- Subject: Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)
- Authentication-results: sourceware.org; auth=none
- References: <1466207668-10549-1-git-send-email-ynorov at caviumnetworks dot com> <576915B0 dot 5040706 at huawei dot com> <mvmk2hipyfw dot fsf at hawking dot suse dot de>
On Tuesday, June 21, 2016 1:34:59 PM CEST Andreas Schwab wrote:
> "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
>
> >> @@ -78,9 +79,9 @@
> >>
> >> #ifdef CONFIG_COMPAT
> >> #define TASK_SIZE_32 UL(0x100000000)
> >> -#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
> >> +#define TASK_SIZE (is_compat_task() ? \
> >> TASK_SIZE_32 : TASK_SIZE_64)
> >> -#define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
> >> +#define TASK_SIZE_OF(tsk) (is_compat_thread(tsk) ? \
> > It should be
> > +#define TASK_SIZE_OF(tsk) (is_compat_thread(task_thread_info(tsk)) ? \
> > is_compat_thread takes "struct thread_info *thread" while TASK_SIZE_OF takes
> > "struct task_struct *tsk"tsk.
>
> If that doesn't throw an error does that mean that TASK_SIZE_OF is
> unused?
I think that is correct. On some architectures, TASK_SIZE (which is used)
is defined as TASK_SIZE_OF(current), but the definition above doesn't
do that and there are no other users.
Arnd