This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 21/27] [AARCH64] ILP32: introduce syscalls that pass off_t
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, Yury Norov <yury dot norov at gmail dot com>
- Date: Tue, 21 Jun 2016 10:35:27 +0000
- Subject: Re: [PATCH 21/27] [AARCH64] ILP32: introduce syscalls that pass off_t
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-23-git-send-email-ynorov at caviumnetworks dot com>
On Tue, 21 Jun 2016, Yury Norov wrote:
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/fallocate.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/fallocate64.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/ftruncate.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/ftruncate64.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/llseek.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/lseek.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/mmap.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/posix_fadvise.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/posix_fadvise64.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pread.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pread64.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pwrite.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/pwrite64.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/readahead.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/truncate.c
> create mode 100644 sysdeps/unix/sysv/linux/aarch64/ilp32/truncate64.c
I don't like how you need so many ilp32 files.
Presumably this is a new convention to be followed for all future ilp32
ABIs on 64-bit architectures. Meaning that you should have some sysdeps
macros to say whether this convention is in use and then make either the
sysdeps/unix/sysv/linux files, or the .../generic files, or a new
architecture-independent sysdeps directory, implement that convention.
Note also how Adhemerval recently unified pread / pwrite implementations.
Adding new files for those functions goes against that unification.
--
Joseph S. Myers
joseph@codesourcery.com