This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v8] Add pretty printers for the NPTL lock types
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: libc-alpha at sourceware dot org, Carlos O'Donell <carlos at redhat dot com>
- Date: Mon, 20 Jun 2016 09:42:50 +0530
- Subject: Re: [PATCH v8] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <20160608153304 dot 12910-1-martin dot galvan at tallertechnologies dot com> <20160608153841 dot GA8366 at devel dot intra dot reserved-bit dot com> <CAOKbPbZCbrfM=FRq6e7C3c8uXp9v+BODAoh6Qat7XRwOb5cEHA at mail dot gmail dot com> <20160619164448 dot GA5245 at devel dot intra dot reserved-bit dot com> <CAOKbPbYpRcwJ8QNSgvW9BxkOeTSBnWEGGFRMOY=RSzoK6k1-Bw at mail dot gmail dot com>
On Mon, Jun 20, 2016 at 12:18:37AM -0300, Martin Galvan wrote:
> Thanks for the answer. Can you specify what exactly is it that I'd
> need to do to get this running properly? That is, please tell me,
> step-by-step, exactly what I need to do in gdb/the Makefiles. I know
> very little of this, and won't sink countless more hours dwelling
> within the build system just to get it wrong again.
In Makeconfig there is a conditional that decides whether to use rpath
or rpath-link. Additionally it also decides whether to use the built
dynamic linker or the system dynamic linker. You'll have to enhance
the conditional so that it selects rpath and the built dynamic linker
when in the pretty-printers subdir.
> I don't know if Python's print() will end up in .test-result, but
> yeah, that's definitely something necessary. At least if I can't
> reproduce the failure I can send the new tests to you and we'll be
> able to figure it out from the output.
Yes, it is not a bad idea to print out diagnostic information even in
case of success. The hang (rather, timeout) happens on line 66
('Owner ID': r'{0} \(dead\)') for me.
> Sure. Hopefully nobody else will jump in and tell me to revert any
> additional changes at the last minute :)
Hazards of collaborative community development :)
Siddhesh