This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Export stack_used as __stack_used
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 17 Jun 2016 12:51:19 +0100
- Subject: Re: [PATCH] Export stack_used as __stack_used
- Authentication-results: sourceware.org; auth=none
- References: <20160613112351 dot GA655 at blade dot nx> <1466163476-10459-1-git-send-email-gbenson at redhat dot com>
On 06/17/2016 12:37 PM, Gary Benson wrote:
> Hi all,
>
> This commit renames "stack_used" as "__stack_used" and changes it from
> a static variable in allocatestack.c to an internally exported symbol
> available to all nptl source files. This fixes bug 17629 (and thus
> GDB PR 9635).
Thanks!
>
> Is this ok to commit?
I'd have preferred to split the renaming bits out, alone, as that's
the part that actually fixes the bug, and leave the (internally) exporting
the symbol and the iterate_thread_list hunk as a patch of the Infinity
series, where it's needed.
--
Pedro Alves