This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedef --old-style is a no-op
- From: Marko Myllynen <myllynen at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 11 Jun 2016 16:01:51 +0300
- Subject: Re: [PATCH] localedef --old-style is a no-op
- Authentication-results: sourceware.org; auth=none
- References: <574835CB dot 5000401 at redhat dot com> <20160527181644 dot GK26300 at vapier dot lan> <574BC6FF dot 5030007 at redhat dot com> <alpine dot DEB dot 2 dot 20 dot 1606022230260 dot 9542 at digraph dot polyomino dot org dot uk> <20160603021640 dot GU7717 at vapier dot lan> <20160611054406 dot GH4053 at vapier dot lan>
- Reply-to: Marko Myllynen <myllynen at redhat dot com>
Hi,
On 2016-06-11 08:44, Mike Frysinger wrote:
> On 02 Jun 2016 22:16, Mike Frysinger wrote:
>> On 02 Jun 2016 22:31, Joseph Myers wrote:
>>> On Mon, 30 May 2016, Marko Myllynen wrote:
>>>> On 2016-05-27 21:16, Mike Frysinger wrote:
>>>>> On 27 May 2016 14:55, Marko Myllynen wrote:
>>>>>> The --old-style option for localedef is a no-op. Is the patch below to
>>>>>> reflect this worth the effort (considering translations) or should we
>>>>>> leave it as is? (I've already submitted a patch to man pages upstream
>>>>>> to adjust the localedef(1) man page.)
>>>>>
>>>>> this code has been dead for 16 years afaict. i think that's more than
>>>>> enough time to let people update their scripts, so let's just drop the
>>>>> option entirely.
>>>>
>>>> Ok, how about the patch below? (Please fine-tune the ChangeLog entry if
>>>> needed.)
>>>
>>> In my view such a feature removal (even of a no-op feature) merits a NEWS
>>> entry as well.
>>
>> np. if no one else has concerns, i can take of merging it.
>
> done!
Thanks for taking care of this, Mike. However, isn't the NEWS entry a
bit unclear at the moment, how about something like this instead?
2016-06-11 Marko Myllynen <myllynen@redhat.com>
* NEWS (2.24): Adjust --old-style removal text.
---
NEWS | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 4334578..9b5d9fe 100644
--- a/NEWS
+++ b/NEWS
@@ -36,8 +36,9 @@ Version 2.24
* The deprecated __malloc_initialize_hook variable has been removed from the
API.
-* The long unused --old-style flag has been removed. It hasn't done anything
- in over 16 years. Scripts using this flag can safely drop it.
+* The long unused localedef --old-style option has been removed. It hasn't
+ done anything in over 16 years. Scripts using this option can safely
+ drop it.
Security related changes:
Thanks,
--
Marko Myllynen