This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Fix i386/x86_64 log1pl (sNaN) (bug 20229) [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 8 Jun 2016 23:12:16 +0000
- Subject: Fix i386/x86_64 log1pl (sNaN) (bug 20229) [committed]
- Authentication-results: sourceware.org; auth=none
The i386/x86_64 versions of log1pl return sNaN for sNaN input. This
patch fixes them to add a NaN input to itself so that qNaN is returned
in this case.
Tested for x86_64 and x86. Committed.
2016-06-08 Joseph Myers <joseph@codesourcery.com>
[BZ #20229]
* sysdeps/i386/fpu/s_log1pl.S (__log1pl): Add NaN input to itself.
* sysdeps/x86_64/fpu/s_log1pl.S (__log1pl): Likewise.
* math/libm-test.inc (log1p_test_data): Add sNaN tests.
diff --git a/math/libm-test.inc b/math/libm-test.inc
index e2a4ed3..4371c4c 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -9049,6 +9049,8 @@ static const struct test_f_f_data log1p_test_data[] =
TEST_f_f (log1p, plus_infty, plus_infty, ERRNO_UNCHANGED),
TEST_f_f (log1p, qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
TEST_f_f (log1p, -qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
+ TEST_f_f (log1p, snan_value, qnan_value, INVALID_EXCEPTION),
+ TEST_f_f (log1p, -snan_value, qnan_value, INVALID_EXCEPTION),
AUTO_TESTS_f_f (log1p),
};
diff --git a/sysdeps/i386/fpu/s_log1pl.S b/sysdeps/i386/fpu/s_log1pl.S
index 98965fa..0fd05cb 100644
--- a/sysdeps/i386/fpu/s_log1pl.S
+++ b/sysdeps/i386/fpu/s_log1pl.S
@@ -70,6 +70,7 @@ ENTRY(__log1pl)
3: jp 4b // in case x is ?Inf
fstp %st(1)
fstp %st(1)
+ fadd %st(0)
ret
END (__log1pl)
diff --git a/sysdeps/x86_64/fpu/s_log1pl.S b/sysdeps/x86_64/fpu/s_log1pl.S
index e83f64d..947e5e4 100644
--- a/sysdeps/x86_64/fpu/s_log1pl.S
+++ b/sysdeps/x86_64/fpu/s_log1pl.S
@@ -68,6 +68,7 @@ ENTRY(__log1pl)
jnz 4b // in case x is ?Inf
fstp %st(1)
fstp %st(1)
+ fadd %st(0)
ret
END (__log1pl)
--
Joseph S. Myers
joseph@codesourcery.com