This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- From: guido guido <guido at trentalancia dot net>
- To: libc-alpha <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Tue, 31 May 2016 23:19:58 +0200 (CEST)
- Subject: Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- Authentication-results: sourceware.org; auth=none
- References: <1464635653 dot 24965 dot 5 dot camel at trentalancia dot net> <1464700854 dot 24965 dot 21 dot camel at trentalancia dot net> <574DA91E dot 9040508 at linaro dot org> <1464708782 dot 2379 dot 12 dot camel at trentalancia dot net> <574DB2E3 dot 4020405 at redhat dot com> <1464714039 dot 2379 dot 30 dot camel at trentalancia dot net> <574DE05C dot 1010803 at linaro dot org> <1464722661 dot 2379 dot 61 dot camel at trentalancia dot net> <574DE8F3 dot 3090306 at linaro dot org> <1464724652 dot 2379 dot 71 dot camel at trentalancia dot net> <574DF019 dot 5010208 at linaro dot org> <2004859717 dot 277531 dot 1464727166214 dot JavaMail dot open-xchange at popper06 dot register dot it> <574DFAA4 dot 2040001 at linaro dot org>
- Reply-to: guido guido <guido at trentalancia dot net>
Hello Adhemerval.
On Tue, 31/05/2016 at 17.57 -0300, Adhemerval Zanella wrote:
[...]
> Btw, I can build GLIBC --enable-nss-crypt on Fedora 23 without any
> patch. I presume it is due some distro changes, but your initial
> configure patch also does not break it (which is good).
Yes, it must be due to distribution patches, most probably patches to those
Mozilla NSS header files that use the Mozilla NSPR header files.
For example, as already pointed out:
#include "prtypes.h" ===> #include <nspr/prtypes.h>
I suppose the Mozilla NSS (and NSPR) library hasn't been initially designed to
be used as a standalone library.
> Again, I do not think this patch is correct.
If you think this patch is not correct, simply use the other one then.
Best regards,
Guido Trentalancia