This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 06/14] Replace M_PI2l with pi_2_d in libm-test.inc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 23 May 2016 22:57:18 +0000
- Subject: Re: [PATCHv2 06/14] Replace M_PI2l with pi_2_d in libm-test.inc
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1463779745 dot git dot murphyp at linux dot vnet dot ibm dot com> <82462d6a31a07e67c8142a7b5b506c8e0c508a62 dot 1463779745 dot git dot murphyp at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 20 dot 1605231651560 dot 17954 at digraph dot polyomino dot org dot uk> <e4e1e01b-4d8a-b730-9c3c-edae25477339 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 20 dot 1605232006270 dot 7571 at digraph dot polyomino dot org dot uk> <6349d13d-5342-d6c9-0b65-2c005ac46dce at linux dot vnet dot ibm dot com>
On Mon, 23 May 2016, Paul E. Murphy wrote:
> That seems reasonable. Though, wouldn't it be much simpler to punt
> these tests to auto-libm-test-in/gen-auto-libm-tests.c and have it more
> accurately compute correctly rounded constants for each format and
> rounding mode? That also seems to imply the inputs may also be
> sensitive to rounding mode.
These are[*] tests with infinities and NaNs as inputs, or as at least one
exact part of a complex result. gen-auto-libm-tests doesn't currently
handle infinities or NaNs as inputs or exact results (as opposed to
overflowing results), and I'm not particularly confident that MPC handles
all such cases the way we want (taking due account of changes in C11 and
in DRs).
[*] Except for tests of complex inverse trig and hyperbolic functions with
finite inputs and results, not moved to auto-libm-test-in because the MPC
functions are very slow in some cases and so moving them would make
gen-auto-libm-tests take probably hours to run.
--
Joseph S. Myers
joseph@codesourcery.com