This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]
- From: Anders Kaseorg <andersk at mit dot edu>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 2 May 2016 06:16:12 -0400 (EDT)
- Subject: Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1604221400580 dot 60537 at buzzword-bingo dot mit dot edu> <87eg9wjynn dot fsf at mid dot deneb dot enyo dot de> <alpine dot DEB dot 2 dot 10 dot 1604231408240 dot 60537 at buzzword-bingo dot mit dot edu> <alpine dot DEB dot 2 dot 10 dot 1604271134490 dot 60537 at buzzword-bingo dot mit dot edu> <572102BC dot 8050906 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1604301914310 dot 48504 at buzzword-bingo dot mit dot edu> <572725A0 dot 8080508 at redhat dot com>
On Mon, 2 May 2016, Florian Weimer wrote:
> I wasn't aware of that, sorry.
>
> I have looked at the patch again, and I think it is technically
> incorrect. The proper way to fix this would be to install a resolver
> callback which does nothing, and free the resolver state only if there
> is *no* callback (because we know we own it).
>
> But we only ever use the thread-local resolver state anyway, so I'm just
> going to remove this code.
I will be happy to see the problem resolved however you see fit.
(If you think this code is incorrect, consider also fixing/deleting the
code in __hesiod_res_set that it was copied from.)
Thanks,
Anders