Re: [PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]

[Florian Weimer <fweimer at redhat dot com>]

On 04/27/2016 05:36 PM, Anders Kaseorg wrote:
> On Sat, 23 Apr 2016, Anders Kaseorg wrote:
> > Thanks for the review!
> >
> > > [â]
> >
> > hesiod/hesiod.c is not in GNU style; I preserved its existing style as per
> > https://sourceware.org/glibc/wiki/Style_and_Conventions#Files_not_formatted_according_to_the_GNU_standard.
> >
> > > [â]
> >
> > I agree: this file is only used in nss_hesiod, whose only exported symbols
> > are the NSS interface.
> >
> > Also, the test I used is the same as what __hesiod_res_set already uses
> > before calling res_nclose.  This may not be strong evidence by itself,
> > because it happens that __hesiod_res_set is never called in a way that
> > satisfies this test, but at least itâs consistent.
>
> Is this ready to be committed, or do you still have concerns?

Yes please, this change looks fine.

I'll add Hesiod tests to the resolver test suite eventually.

Florian