This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev

From: Mike Frysinger <vapier at gentoo dot org>
To: Brian Norris <computersforpeace at gmail dot com>
Cc: linux-mtd at lists dot infradead dot org, Michael Kerrisk <mtk dot manpages at gmail dot com>, linux-man at vger dot kernel dot org, libc-alpha at sourceware dot org
Date: Mon, 18 Apr 2016 12:49:08 -0400
Subject: Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev
Authentication-results: sourceware.org; auth=none
References: <1460860245-14895-1-git-send-email-vapier at gentoo dot org> <20160418163926 dot GB52272 at google dot com>

On 18 Apr 2016 09:39, Brian Norris wrote:
> On Sat, Apr 16, 2016 at 10:30:45PM -0400, Mike Frysinger wrote:
> > These functions have always been defined in sys/sysmacros.h under
> > Linux C libraries.  For some, including sys/types.h implicitly
> > includes that as well, but glibc wants to deprecate that, and some
> > others already have.  Include the header explicitly for the funcs.
> > 
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> Patch looks fine to me, thanks. Pushed to mtd-utils.git.
> 
> But I don't see this change documented anywhere. (Helpfully, I do see
> the change from your other patch -- _BSD_SOURCE -> _DEFAULT_SOURCE --
> documented though!) Should the man-pages project be updated? I see the
> latest makedev(5) still recommends #include <sys/types.h>.

glibc hasn't moved forward (yet).  we should update the man pages now
though to mention sys/sysmacros.h.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- [PATCH] makedev(3): point people at sys/sysmacros.h
  - From: Mike Frysinger

References:
- Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev
  - From: Brian Norris

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]