This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Thu, 14 Apr 2016 09:17:02 -0700
Subject: Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
Authentication-results: sourceware.org; auth=none
References: <570BC02D dot 2040901 at redhat dot com> <570BC840 dot 6060807 at cs dot ucla dot edu> <570F8B9B dot 6020402 at redhat dot com>

On 04/14/2016 05:22 AM, Florian Weimer wrote:

+	  /* Deallocate any previously allocated buffer because it is
+	     too small.  */
+	  if (__glibc_unlikely (workstart != NULL))
+	    free (workstart);
  	  if (__glibc_unlikely (prec >= INT_MAX / sizeof (CHAR_T) - 32))

Why don't we need a 'workstart = NULL' after freeing workstart, which isthe pattern used elsewhere? If it's not needed here, it'd be helpful tohave a comment saying why not.

Follow-Ups:
- Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
  - From: Florian Weimer

References:
- [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
  - From: Florian Weimer
- Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
  - From: Paul Eggert
- Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]