This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] localedata: CLDRv29: update LC_ADDRESS.country_num values


On 12 Apr 2016 10:17, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > On 12 Apr 2016 10:05, Andreas Schwab wrote:
> >> Mike Frysinger <vapier@gentoo.org> writes:
> >> > On 12 Apr 2016 09:53, Andreas Schwab wrote:
> >> >> Mike Frysinger <vapier@gentoo.org> writes:
> >> >> > --- a/localedata/locales/ca_AD
> >> >> > +++ b/localedata/locales/ca_AD
> >> >> > @@ -96,7 +96,7 @@ postal_fmt    "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
> >> >> >  <U004E><U0025><U0063><U0025><U004E>"
> >> >> >  country_ab2 "<U0041><U0044>"
> >> >> >  country_ab3 "<U0041><U004E><U0044>"
> >> >> > -country_num 20
> >> >> > +country_num 020
> >> >> 
> >> >> This is a plain number so the leading zero is not significant.
> >> >
> >> > i documented this in the commit message
> >> 
> >> That doesn't make it correct.
> >
> > nor does it make it incorrect.  i've provided justification for the
> > change at this point.
> 
> "Add leading 0 prefix" is not justification.

like i already said, read the *commit message*.  you're quoting the
ChangeLog which does *not* include justification.  ChangeLog's are
dumb files that only list *what* changed, not *why*.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]