This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH v4] Add pretty printers for the NPTL lock types
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: libc-alpha at sourceware dot org, carlos at redhat dot com, tom at tromey dot com, daniel dot gutson at tallertechnologies dot com
- Date: Mon, 4 Apr 2016 21:25:27 +0530
- Subject: Re: [PING][PATCH v4] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1459775243-3092-1-git-send-email-martin dot galvan at tallertechnologies dot com>
> As for the install directory, I discussed this with Mike Frysinger and we agreed
> that this should be handled by the maintainers of each distro, since the paths
> may vary from one distro to another. We also agreed that this issue shouldn't
> block the merging of this patch either.
I disagree. While distributions will eventually decide on where to
place the pretty printers, the locations are not going to be as
different as you think. libstdc++ has already set an example with
their setup and it is a good act to follow IMO. On my Fedora box, the
libstdc++ pretty-printer scripts are all installed in
/usr/share/gcc-nvr/python/libstdc++/v6 and the auto-load file is in
/usr/share/gdb/auto-load/usr/lib64/libstdc++.so.6.0.21-gdb.py. It is
similar on a Ubuntu installation I have, with the lib64 replaced by
their multiarch hierarchy.
So I would recommend using that as an example and installing glibc
pretty printers accordingly so that during packaging, distributions
only have to make standard adjustments to their paths and those
installing by hand also don't have to manually copy over files.
You could do that as a separate patch to this one though. The general
approach otherwise looks good to me. I will try to do a more detailed
review this weekend.
Siddhesh