This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH V3] When disabling SSE, make sure -fpmath is not set to use SSE either

From: Mike Frysinger <vapier at gentoo dot org>
To: Khem Raj <raj dot khem at gmail dot com>
Cc: libc-alpha at sourceware dot org
Date: Sat, 2 Apr 2016 22:16:12 -0400
Subject: Re: [PATCH V3] When disabling SSE, make sure -fpmath is not set to use SSE either
Authentication-results: sourceware.org; auth=none
References: <1459439112-30153-1-git-send-email-raj dot khem at gmail dot com>

On 31 Mar 2016 08:45, Khem Raj wrote:
>  # Make sure no code in ld.so uses mm/xmm/ymm/zmm registers on i386 since
>  # the first 3 mm/xmm/ymm/zmm registers are used to pass vector parameters
>  # which must be preserved.
> +# with SSE disabled, ensure -fpmath is not set to use sse either, this
> +# avoids below compiler diagnostic
> +# warning: SSE instruction set disabled, using 387 arithmetics
> +# which is treated as error with -Werror

the flag change looks fine, but this comment seems excessive.
i think it should just read:
# With SSE disabled, ensure -fpmath is not set to use sse either.
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]