This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add Roman numerals in *printf
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Matteo Croce <matteo at openwrt dot org>, libc-alpha at sourceware dot org
- Date: Fri, 1 Apr 2016 10:22:11 -0400
- Subject: Re: [PATCH] Add Roman numerals in *printf
- Authentication-results: sourceware.org; auth=none
- References: <1459503215-21039-1-git-send-email-matteo at openwrt dot org>
On 04/01/2016 05:33 AM, Matteo Croce wrote:
> This patch adds the `%r' modifier in all the *printf functions,
> which can be used to represent a number in Roman numerals.
> This has two big advantages:
High-level review:
(a) Standardize '%r' and '%R' first.
As Adhemerval notes, this needs to go through POSIX or ISO C first
to standardize the '%r' and '%R' modifiers.
Working with the Austin Group is pretty easy actually, you need
to file a ticket with their system and discuss the change to the
standard:
Austin Group homepage:
http://www.opengroup.org/austin/
Austin Group bug tracker:
http://austingroupbugs.net/main_page.php
(b) Follow the contribution checklist.
After you have standardized the modifiers you go through the
contribution checklist here:
https://sourceware.org/glibc/wiki/Contribution%20checklist
(c) Needs tests.
You need tests for all of the characters you are adding, and
the output they might generate.
--
Cheers,
Carlos.