Re: Remove __ASSUME_GETDENTS64_SYSCALL

[Mike Frysinger <vapier at gentoo dot org>]

On 11 Mar 2016 17:54, Joseph Myers wrote:
> This patch removes the __ASSUME_GETDENTS64_SYSCALL macro, as its
> definition is constant given the new kernel version requirements (and
> was constant anyway before those requirements except for MIPS n32).
> 
> Note that the "#ifdef __NR_getdents64" conditional *is* still needed,
> because MIPS n64 only has the getdents syscall (being a 64-bit ABI,
> that syscall is 64-bit; the difference between the two on 64-bit
> architectures is where d_type goes).  If MIPS n64 were to gain the
> getdents64 syscall and we wanted to use it conditionally on the kernel
> version at runtime we'd have to revert this patch, but I think that's
> unlikely (and in any case, we could follow the simpler approach of
> undefining __NR_getdents64 if the syscall can't be assumed, just like
> we do for accept4 / recvmmsg / sendmmsg syscalls on architectures
> where socketcall support came first).

lgtm
-mike

Attachment: signature.asc
Description: Digital signature