This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Siddhesh Poyarekar <sid at reserved-bit dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Mon, 21 Mar 2016 12:58:20 -0300
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160209155450 dot GE1904 at devel dot intra dot reserved-bit dot com> <CAOKbPbYPtn5mMpwGGD-HccXnhNz+eymiJ7Xwe_4WOnesYkw5=A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602091743430 dot 29757 at digraph dot polyomino dot org dot uk> <CAOKbPba5MGw8XCXRSvapfADD1v_0FoVYhUeJUp01YBXyELLMkg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602101301131 dot 23420 at digraph dot polyomino dot org dot uk> <56BCB9C7 dot 6000100 at redhat dot com> <CAOKbPbZMt+ozv8dPbC8hpZr6yw2d2HcV4OskRP+Pk-i3oYu=nQ at mail dot gmail dot com> <56D5DFE3 dot 5010401 at redhat dot com> <CAOKbPbY_TPXBuFWT_eZCOBKiF-uSWZndAT3cuL3ZvZF+htbCRQ at mail dot gmail dot com> <CAOKbPbY0QW-KvhegDbs3NCuv-hHKyf-peuL1aBon+YTCt2SfEg at mail dot gmail dot com> <56E249E9 dot 4060404 at redhat dot com> <CAOKbPbYXgQyM8Gk-R4poMsdHz6eZ6=9ynq=hu=E8yrignf3N-w at mail dot gmail dot com> <56E6FF80 dot 3080202 at redhat dot com> <CAOKbPbaVpUk0VggUGivbaY9fDHMf0-RrYjsYOGLRHEOKy+Ycbw at mail dot gmail dot com> <CAOKbPbaTB4t1YX=Qu+gcSJuPvxc+FVZis2cRCsVfr4bnn1BCvw at mail dot gmail dot com>
I went a bit deeper and I think the issue is that I'm adding the test
programs to 'test-srcs', which compiles them including libc-symbols.h.
I added them to test-srcs to make sure that even if we don't run the
test scripts, the test programs would be compiled.
The workaround would be adding a new target which compiled the test
programs by hand, like this:
$(tests-pretty-printers-out): $(objpfx)%.out: %.c
$(CC) $(CFLAGS) -o $@ $*.c
That way, we could make tests-pretty-printers-out be a prerequisite of
the test target, which would run the python scripts only if requested
by run-built-tests.
I'm not sure if this is the cleanest way to do it, tough.
Additionally, I'd still need to know how to link against libpthread.
I'd appreciate it if anyone could give me a hand on how to write the
Makefile.