This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Delete dead code? [BZ 19653]

From: Mike Frysinger <vapier at gentoo dot org>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Bill Parker <wp02855 at gmail dot com>
Date: Mon, 21 Mar 2016 02:19:00 -0400
Subject: Re: Delete dead code? [BZ 19653]
Authentication-results: sourceware.org; auth=none
References: <CALoOobPWnKob6y-po+dvbT-YT5hCgxZwxd-vzrZcs_gEXcg-ig at mail dot gmail dot com>

On 20 Mar 2016 11:35, Paul Pluzhnikov wrote:
> Quoting from https://sourceware.org/bugzilla/show_bug.cgi?id=19653
> "if this is re-enabled in the future, it could segmentation fault
> without the check for NULL from malloc()."
> 
> AFAICT, the code comes from:
> 
> commit 49633efbcc056cc97928b22ff274b5774839bfae
> Author: Roland McGrath <roland@gnu.org>
> Date:   Wed Jul 26 00:13:55 1995 +0000
> 
>     New file, based on NET2 code but with DES code removed.
> 
> and has been ifdef'd out since then.
> 
> Should we just delete the '#if 0'd blocks?

it's all dead code (since it's only used by RPC), so deleting #if 0
here seems fine to me.  it's not like we're going to be taking any
more enhancements.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- Delete dead code? [BZ 19653]
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]