This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Mar 2016 14:55:48 -0800 (PST)
- Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h
- Authentication-results: sourceware.org; auth=none
- References: <1457049161-13783-1-git-send-email-hjl dot tools at gmail dot com> <CAMe9rOqmnA8TOOEo_KbxYnxaDDvzEcb+hqLHwK=dZ5J75W8d5Q at mail dot gmail dot com> <20160311214735 dot 4CAE52C3C21 at topped-with-meat dot com> <CAMe9rOovPk+-DokpWoR7c6cG4bHydhaXPyNbZPyL6fRcapoD1Q at mail dot gmail dot com> <20160311220031 dot 3A5672C3BC5 at topped-with-meat dot com> <CAMe9rOrHS0g_EZ7dgkz02SgHoxqHwp5yazt3fR9Qj9NvYG+1Jg at mail dot gmail dot com> <20160311222939 dot 654342C3C24 at topped-with-meat dot com> <CAMe9rOo3m_x-EpY2w=ZzbLDd2MjjLhrBY6fP-ngDFGDG-Z+94A at mail dot gmail dot com> <874mcc636j dot fsf at mid dot deneb dot enyo dot de>
> Roland committed a fix which included <cpu-features.h> (commit
> 3bd80c0de2f8e7ca8020d37739339636d169957e) in tst-audit10.c I assumed
> that this addressed this particular build failure (it does for me with
> GCC 4.7).
That fixed it on the bot too, which is GCC 4.8.4.
> Ah, you removed that flag in 6aa3e97e2530f9917f504eb4146af119a3f27229.
> So you need to adjust tst-audit10 for this change.
Indeed.
> > -tests += tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7 tst-audit10
> > +tests += tst-audit3 tst-audit4 tst-audit5 tst-audit6 tst-audit7
> > +
> > +ifeq (yes,$(config-cflags-avx512))
> > +tests += tst-audit10
> > +endif
>
> The test should be marked as UNSUPPORTED instead.
That is adequately covered inside the test already (at runtime).
There is no reason to conditionalize building it.