This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] glob: Avoid copying the d_name field of struct dirent [BZ #19779]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Mar 2016 23:02:46 +0100
- Subject: Re: [PATCH] glob: Avoid copying the d_name field of struct dirent [BZ #19779]
- Authentication-results: sourceware.org; auth=none
- References: <56E339A7 dot 7060704 at redhat dot com> <56E33FE4 dot 4080605 at cs dot ucla dot edu>
On 03/11/2016 11:00 PM, Paul Eggert wrote:
> I merely read the patch. Comments:
>
>> +static void
>> +convert_dirent (const struct dirent *source, struct abstract_dirent
> *target)
>
> Since this is all inlined, how about if making it a pure function, with
> a signature like this instead?
>
> static struct abstract_dirent
> convert_dirent (struct dirent const *source)
>
> That should be a bit cleaner.
The file is in gnulib, I feared that gnulib has to support compilers
which cannot return structs.
> Otherwise, it looks good.
Thanks.
Florian