This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Siddhesh Poyarekar <sid at reserved-bit dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Fri, 11 Mar 2016 11:30:35 -0300
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160209155450 dot GE1904 at devel dot intra dot reserved-bit dot com> <CAOKbPbYPtn5mMpwGGD-HccXnhNz+eymiJ7Xwe_4WOnesYkw5=A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602091743430 dot 29757 at digraph dot polyomino dot org dot uk> <CAOKbPba5MGw8XCXRSvapfADD1v_0FoVYhUeJUp01YBXyELLMkg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602101301131 dot 23420 at digraph dot polyomino dot org dot uk> <56BCB9C7 dot 6000100 at redhat dot com> <CAOKbPbZMt+ozv8dPbC8hpZr6yw2d2HcV4OskRP+Pk-i3oYu=nQ at mail dot gmail dot com> <56D5DFE3 dot 5010401 at redhat dot com> <CAOKbPbY_TPXBuFWT_eZCOBKiF-uSWZndAT3cuL3ZvZF+htbCRQ at mail dot gmail dot com> <CAOKbPbY0QW-KvhegDbs3NCuv-hHKyf-peuL1aBon+YTCt2SfEg at mail dot gmail dot com> <56E249E9 dot 4060404 at redhat dot com>
On Fri, Mar 11, 2016 at 1:30 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> This is really awesome.
>
> From a high level I think the testing is coming along very nicely.
Thanks a lot! I'm glad to hear that.
> One things I'd like to see:
>
> * Test timeouts? What if the tests get stuck?
> - I don't see how you control the timeouts or time them to
> the existing TIMEOUTFACTOR or define default timeouts.
pexpect.spawn takes a 'timeout' parameter, which tells it how long it
should wait for the target to output a matching response after each
call to expect(). If the expect() call times out, an exception is
raised and the test exits with code 1.
I arbitrarily set that timeout to 1 second, but I can change that. Is
TIMEOUTFACTOR an environment variable you can set when running make
check?