This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libio/vasprintf.c: Always use realloc.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <sid at reserved-bit dot com>
- Date: Fri, 4 Mar 2016 16:51:28 -0500
- Subject: Re: [PATCH] libio/vasprintf.c: Always use realloc.
- Authentication-results: sourceware.org; auth=none
- References: <565870B7 dot 2020901 at redhat dot com> <565DCC79 dot 3060006 at redhat dot com> <20160304184239 dot ACC522C3BBC at topped-with-meat dot com>
On 03/04/2016 01:42 PM, Roland McGrath wrote:
>> I'm going to drop this until I can get a benchtest to show this
>> is better than before.
>
> IMHO if benchmarks simply show it's not clearly worse, then you should go
> ahead because it simplifies the code. If the motivation for a change is
> not performance alone, then it doesn't need to demonstrate a performance
> improvement per se.
It's hard to tell. I'd like to prove it to myself that it's generating
better code.
c.