This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/4] Consolidate pwrite/pwrite64 implementations

From: Mike Frysinger <vapier at gentoo dot org>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org, Adhemerval Zanella <adhemerval dot zanella at linaro dot com>
Date: Tue, 23 Feb 2016 13:51:25 -0500
Subject: Re: [PATCH 4/4] Consolidate pwrite/pwrite64 implementations
Authentication-results: sourceware.org; auth=none
References: <1456240627-18774-1-git-send-email-adhemerval dot zanella at linaro dot org> <1456240627-18774-5-git-send-email-adhemerval dot zanella at linaro dot org>

On 23 Feb 2016 12:17, Adhemerval Zanella wrote:
> 	* sysdeps/unix/sysv/linux/arm/pwrite.c: Remove file.
> 	* sysdeps/unix/sysv/linux/arm/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/sh/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/sh/pwrite64.c: Likewise.

you aren't removing the mips/sh implementations anymore

> --- a/sysdeps/unix/sysv/linux/mips/pwrite.c
> +++ b/sysdeps/unix/sysv/linux/mips/pwrite.c
>
> +/* The n32 have sizeof(off_t) != sizeof(off64_t) so we can't strong/weak
> +   alias the pwrite to pwrite64.  We undefine the __ASSUME_WORDSIZE64_ILP32
> +   so two implementation are built.  */
> +#if _MIPS_SIM == _ABIN32
> +# undef __ASSUME_WORDSIZE64_ILP32
>  #endif
>
> +#include <sysdeps/unix/sysv/linux/pwrite.c>

this style seems fragile to me.  would it not be better to add a
specific knob for files to set ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 4/4] Consolidate pwrite/pwrite64 implementations
  - From: Adhemerval Zanella

References:
- [PATCH v2 0/4] Cancellation entrypoint refactor
  - From: Adhemerval Zanella
- [PATCH 4/4] Consolidate pwrite/pwrite64 implementations
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]