This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add missing include to posix/tst-dir.c
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 22 Feb 2016 16:23:00 +0100
- Subject: Re: [PATCH] Add missing include to posix/tst-dir.c
- Authentication-results: sourceware.org; auth=none
- References: <56B8C43A dot 4040705 at redhat dot com> <1456149467-19460-1-git-send-email-tuliom at linux dot vnet dot ibm dot com> <878u2c977i dot fsf at mid dot deneb dot enyo dot de> <874md0rf4j dot fsf at linux dot vnet dot ibm dot com>
* Tulio Magno Quites Machado Filho:
> Florian Weimer <fw@deneb.enyo.de> writes:
>
>> * Tulio Magno Quites Machado Filho:
>>
>>> A recent change to posix/tst-dir.c started to use macros from
>>> libc-internal.h but didn't include it, causing build issues.
>>>
>>> 2016-02-22 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>>>
>>> * posix/tst-dir.c: Include libc-internal.h.
>>
>> I have never seen a need to include <libc-internal.h> like this
>> before. How are you building the tests that you need this?
>
> There is nothing special:
> configure --prefix=/usr --with-cpu=power8 --enable-add-ons
> make
> make -k check
>
> I'm using GCC 4.8.4.
Thanks, found the difference, it's due to the #includes in
sysdeps/i386/nptl/tls.h and sysdeps/x86_64/nptl/tls.h. Perhaps we can
get rid of that to avoid future such breakage.
Patch is fine.