This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add missing include to posix/tst-dir.c
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: libc-alpha at sourceware dot org
- Cc:
- Date: Mon, 22 Feb 2016 11:31:08 -0300
- Subject: Re: [PATCH] Add missing include to posix/tst-dir.c
- Authentication-results: sourceware.org; auth=none
- References: <56B8C43A dot 4040705 at redhat dot com> <1456149467-19460-1-git-send-email-tuliom at linux dot vnet dot ibm dot com> <878u2c977i dot fsf at mid dot deneb dot enyo dot de>
Florian Weimer <fw@deneb.enyo.de> writes:
> * Tulio Magno Quites Machado Filho:
>
>> A recent change to posix/tst-dir.c started to use macros from
>> libc-internal.h but didn't include it, causing build issues.
>>
>> 2016-02-22 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>>
>> * posix/tst-dir.c: Include libc-internal.h.
>
> I have never seen a need to include <libc-internal.h> like this
> before. How are you building the tests that you need this?
There is nothing special:
configure --prefix=/usr --with-cpu=power8 --enable-add-ons
make
make -k check
I'm using GCC 4.8.4.
It seems we already have some testcases doing that:
$ find . -type f \( -name 'test-*' -o -name 'tst-*' -o -name 'bug*' \) \
| xargs grep -n libc-internal.h
./stdio-common/tst-printfsz.c:5:#include <libc-internal.h>
./stdio-common/tst-unlockedio.c:23:#include <libc-internal.h>
./stdio-common/test-vfprintf.c:28:#include <libc-internal.h>
./stdio-common/tst-sprintf.c:5:#include <libc-internal.h>
./stdio-common/bug21.c:2:#include <libc-internal.h>
./stdio-common/tst-printf.c:29:#include <libc-internal.h>
./string/tst-endian.c:6:#include <libc-internal.h>
./misc/tst-error1.c:6:#include <libc-internal.h>
--
Tulio Magno