This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 17 Feb 2016 13:36:20 -0800
- Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tML81iuKQMKRU-T4Fw0+=sYk0q_BNavMGagt21VcYvzQ at mail dot gmail dot com> <CAMe9rOp7BF2avdWbGTbsxuYQV_rmXSxzDUAwz+nHK-GhWqPKJA at mail dot gmail dot com> <CAMXFM3sG90jn3Em-REfaqtj3OGAjh51OcO=yn1qHqJ4aStkPrg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602111641250 dot 29940 at digraph dot polyomino dot org dot uk> <CAMXFM3uxH=0DHnwikPjs2AobQ0kxOqKg+j=CuOWX=RLB_i8hxg at mail dot gmail dot com> <CAMe9rOoWy+hqiCOKqFx0nOFVRT_kBETJ5hYE+cY6pFWUke=tkw at mail dot gmail dot com> <CAMXFM3vG1DNELfGaOOoUvRDGgrGWL4m3M8+5ngPg8RPnCLqUog at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602161347240 dot 26462 at digraph dot polyomino dot org dot uk> <CAMXFM3tXQi0wRFNN1gyu-T3C7g_EWPxMfhK4wexADGtcPojNZg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602171711080 dot 18373 at digraph dot polyomino dot org dot uk> <CAMXFM3uYod=-mzjLnntwjtu5mAc3bt=pzSk6G7FiO_JHtpvTZQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602171842400 dot 18373 at digraph dot polyomino dot org dot uk> <CAMXFM3tB9X7xVSau3ADnGw7_QZLUoY1wVwa0Y8FLDH34vwJJBQ at mail dot gmail dot com> <CAMe9rOpCqmoSXE4+ci5p9PX-cCSrpTD=nJt4URYSSQNSSu47gg at mail dot gmail dot com> <CAMXFM3veSy9SCa=Ke15zON_h+_TD7eK3k8QNS2mrqfBKDDs+vA at mail dot gmail dot com>
On Wed, Feb 17, 2016 at 1:04 PM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
> 2016-02-17 23:06 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>> On Wed, Feb 17, 2016 at 11:30 AM, Andrew Senkevich
>> <andrew.n.senkevich@gmail.com> wrote:
>>> 2016-02-17 21:44 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>>>> On Wed, 17 Feb 2016, Andrew Senkevich wrote:
>>>>
>>>>> Is attached version finally Ok for trunk?
>>>>
>>>> Please resubmit, with the coding style issues fixed and tests moved to
>>>> test-skeleton.c unless there's a reason they can't use it, after the
>>>> freeze is over. This is much too risky to consider during the freeze, and
>>>> would need to wait a while on master before any backports could be
>>>> considered (e.g. the new tests could break the testsuite build in some
>>>> configurations for unforeseen reasons).
>>>
>>> May be separate fix and tests to commit fix earlier?
>>>
>>
>> This is a good idea. Please submit a fix-only patch.
>
> 2016-02-18 Andrew Senkevich <andrew.senkevich@intel.com>
> H.J. Lu <hongjiu.lu@intel.com>
>
> [BZ #19590]
> * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PIC
> relocation.
>
> diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S
> b/sysdeps/x86_64/fpu/svml_finite_alias.S
> index 0062fe4..2dcfc37 100644
> --- a/sysdeps/x86_64/fpu/svml_finite_alias.S
> +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S
> @@ -23,8 +23,7 @@
>
> #define ALIAS_IMPL(alias, target) \
> ENTRY (alias); \
> - call target; \
> - ret; \
> + jmp *target@GOTPCREL(%rip); \
> END (alias)
>
> .text
>
>
> Ok to commit?
>
OK. Please leave BZ 19590 open until testcase is added.
Thanks.
--
H.J.