This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 10 Feb 2016 19:07:16 +0300
- Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tML81iuKQMKRU-T4Fw0+=sYk0q_BNavMGagt21VcYvzQ at mail dot gmail dot com> <56BB2835 dot 4050907 at redhat dot com> <CAMXFM3s=W79Wp=os1w0FuybqO8ygpQEz0mT=Q0-NDnX3wZTiPQ at mail dot gmail dot com> <CAMe9rOp2DW118ohTK0UiMeuw8VtyCCrR9Smr6+rwqYX3mcwzXQ at mail dot gmail dot com>
2016-02-10 16:15 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
> On Wed, Feb 10, 2016 at 4:58 AM, Andrew Senkevich
> <andrew.n.senkevich@gmail.com> wrote:
>> 2016-02-10 15:08 GMT+03:00 Florian Weimer <fweimer@redhat.com>:
>>> On 02/10/2016 12:36 PM, Andrew Senkevich wrote:
>>>
>>>> #define ALIAS_IMPL(alias, target) \
>>>> ENTRY (alias); \
>>>> - call target; \
>>>> + call target@PLT; \
>>>> ret; \
>>>> END (alias)
>>>
>>> This needs a comment why this cannot be a tail call (JMP).
>>
>> Yes, it should be jmp.
>>
>>> Out of curiosity, why is it not possible to avoid this indirection? Why
>>> is this logic required in libmvec_nonshared.a?
>>
>> It is workaround to exclude unnecessary symbol aliases in libmvec.so
>> (BZ #19058).
>>
>
> Can you fold libmvec_nonshared.a into libmvec,so?
It is possible but I am not sure it is Ok with point that unnecessary
ABI extension should be limited..
--
WBR,
Andrew