This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix "make check" failure to build on Ubuntu 14.04 LTS
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, andrew dot senkevich at intel dot com
- Date: Mon, 18 Jan 2016 17:16:35 -0500
- Subject: Re: [patch] Fix "make check" failure to build on Ubuntu 14.04 LTS
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPf=6Lc=1=ZTRK3SuRnfhQw1HChGg96MF_yWx=_iB7zLw at mail dot gmail dot com>
On 01/18/2016 03:40 PM, Paul Pluzhnikov wrote:
> 2016-01-18 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * math/Makefile (libm-vec-tests): Move libraries after wrappers.o
As you identified this is a search order issue.
In practice we should follow:
- Object files.
- Archive files.
- Shared objects.
This results in the most compatible search order possible on all possible
systems and allows archive symbols to override shared objects.
I think your fix is correct. Please check this in to fix Ubuntu.
Cheers,
Carlos.
> diff --git a/math/Makefile b/math/Makefile
> index 8bedef7..222ee6b 100644
> --- a/math/Makefile
> +++ b/math/Makefile
> @@ -295,8 +295,8 @@ $(objpfx)libieee.a: $(objpfx)ieee-math.o
>
> $(addprefix $(objpfx),$(filter-out $(tests-static) $(libm-vec-tests),$(tests))): $(libm)
> $(addprefix $(objpfx),$(tests-static)): $(objpfx)libm.a
> -$(addprefix $(objpfx), $(libm-vec-tests)): $(objpfx)%: $(libm) $(libmvec) \
> - $(objpfx)%-wrappers.o
> +$(addprefix $(objpfx), $(libm-vec-tests)): $(objpfx)%: $(objpfx)%-wrappers.o $(libm) \
> + $(libmvec)
>
> gmp-objs = $(patsubst %,$(common-objpfx)stdlib/%.o,\
> add_n sub_n cmp addmul_1 mul_1 mul_n divmod_1 \